Created by: bkabrda
I have a schema that has a oneOf
with two choices, one is an alias for string and the other for int:
components:
schemas:
Something:
type: object
oneOf:
- $ref: '#/components/schemas/One'
- $ref: '#/components/schemas/Two'
One:
type: string
Two:
type: integer
The problem is that when the API returns a string that has integer in it, e.g. "1234"
, the Jackson library (which has coercion of scalars turned on by default) fails to deserialize the Something
object, as "1234"
deserializes successfully as both Integer
and String
. This PR disables scalar coercion to prevent this, thus making the above example work. (As an additional note, I think we want to have this feature disabled since it is something that other clients don't do)
PR checklist
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand. -
Run the shell script ./bin/generate-samples.sh
to update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/config/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
-
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @bkabrda (2020/01)