Created by: nielspardon
Currently the Java generators generate models with equals
and toIndentedString
methods that use a fully qualified classname java.lang.Object
as the parameter type to compare the object to or generate the indented string for.
I would like to introduce a flag to allow disabling the generation of fully qualified classnames since:
- The PMD source code analyzer flags such an unnecessary use of fully qualified classname by default.
- Other
equals
method generators like the Eclipse generator generate theequals
method with the short classnameObject
by default.
I'm introducing a new additional property called fullyQualifiedClassnames
which is set to true by default to keep the current behavior while allowing to optionally disable the generation of fully qualified classnames for POJOs.
Since I'm not sure whether introducing such a flag is permissible for a minor / patch release I'm targeting this PR at master for now and look forward to your feedback.
@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @bkabrda
PR checklist
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand. -
Run the shell script ./bin/generate-samples.sh
to update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/config/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
-
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.