Created by: ybelenko
- Composer required PHP version set to ^7.2
- Readme PHP version set to >=7.2
- Input spec for samples generation changed to OAS3
It's weird that samples/server/petstore/php-ze-ph/src/App/ErrorMiddleware.php
file has not been regenerated. This file isn't presented in generator templates folder modules/openapi-generator/src/main/resources/php-ze-ph
.
Related #6522 (closed)
PR checklist
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand. -
Run the shell script ./bin/generate-samples.sh
to update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/config/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
-
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
cc @jebentier @dkarlovi @mandrean @jfastnacht @ackintosh @renepardon thanks to @Articus for help with testing