Created by: burberius
PR checklist
-
Read the contribution guidelines. -
Ran the shell script under ./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. -
Filed the PR against the correct branch: master,4.0.x. Default:master. -
Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01)
Description of the PR
I used the forbiddenapis maven plugin with code generated by openapi codegen and it found some problems. So I added the plugin to the openapi-generator parent pom, ran the checks there and fixed all findings. In all java templates I also fixed the findings and generated the samples to check it.
You can read more about the found problems in this article: https://dzone.com/articles/policemans-horror-default