Created by: ityuhui
If the data type of query parameter is "int" or "bool" in OpenAPI Spec, the request url will not be right generated by c-libcurl.
For example, in the function
CoreV1API_listNamespacedPod(..., int limit ,... )
{
...
// query parameters
char *keyQuery_limit = NULL;
int valueQuery_limit ;
keyValuePair_t *keyPairQuery_limit = 0;
if (limit)
{
keyQuery_limit = strdup("limit");
valueQuery_limit = (limit);
keyPairQuery_limit = keyValuePair_create(keyQuery_limit, &valueQuery_limit); <-- limit is only be referred as int *
list_addElement(localVarQueryParameters,keyPairQuery_limit);
}
but in the function
char *assembleTargetUrl(char *basePath,
char *operationParameter,
list_t *queryParameters) {
if(queryParameters != NULL) {
strcat(targetUrl, "?");
list_ForEach(listEntry, queryParameters) {
keyValuePair_t *pair = listEntry->data;
replaceSpaceWithPlus(pair->key);
strcat(targetUrl, pair->key);
strcat(targetUrl, "=");
replaceSpaceWithPlus(pair->value);
strcat(targetUrl, pair->value); <=== valueQuery_limit is not a char *, so this is wrong.
if(listEntry->nextListEntry != NULL) {
strcat(targetUrl, "&");
}
}
}
If we call
CoreV1API_listNamespacedPod(...
10, /* limit */
...);
the targetUrl becomes:
"https://ip:6443/api/v1/namespaces/default/pods?limit=P.xUUU"
My fix is converting the parameter to string
// query parameters
char *keyQuery_limit = NULL;
char * valueQuery_limit = NULL;
keyValuePair_t *keyPairQuery_limit = 0;
if (limit)
{
keyQuery_limit = strdup("limit");
valueQuery_limit = calloc(1,MAX_NUMBER_LENGTH);
snprintf(valueQuery_limit, MAX_NUMBER_LENGTH, "%d", limit);
keyPairQuery_limit = keyValuePair_create(keyQuery_limit, valueQuery_limit);
list_addElement(localVarQueryParameters,keyPairQuery_limit);
}
the targetUrl now is right:
"https://ip:6443/api/v1/namespaces/default/pods?list=10"
PR checklist
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand. -
Run the shell script ./bin/generate-samples.sh
to update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/config/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
-
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@zhemant @michelealbano