Created by: bendrucker
This PR uses url.PathEscape
instead of url.QueryEscape
to escape path parameters. PathEscape
performs what would typically be called "URL encoding" with percents. PathEscape replaces spaces with pluses among other encoding that's suitable for query parameters.
package main
import (
"fmt"
"net/url"
)
func main() {
input := "foo bar"
fmt.Println("QueryEscape:", url.QueryEscape(input))
fmt.Println("PathEscape:", url.PathEscape(input))
}
QueryEscape: foo+bar
PathEscape: foo%20bar
https://play.golang.org/p/3gWzjBhMR9C
Escaping was originally added in #3643.
PR checklist
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand. -
Run the shell script ./bin/generate-samples.sh
to update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/config/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
-
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.