Created by: muttleyxd
PR checklist
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project before. -
Run the shell script(s) under ./bin/
(or Windows batch scripts under.\bin\windows
) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the code or mustache templates for a language ({LANG}
) (e.g. php, ruby, python, etc). -
File the PR against the correct branch: master
,4.3.x
,5.0.x
. Default:master
. -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@ravinikam (2017/07) @stkrwork (2017/07) @etherealjoy (2018/02) @MartinDelille (2018/03)
I tried to use Pistache::Http::serveFile
, and it works, but when the file does not exist, then it will return 500
, instead of 404
. That's because it throws Pistache::Http::HttpError
with 404 code, but it's being caught by catch (std::exception &)
and 500
is returned afterwards, despite original exception having more information.
void MyHandlers::getFile(std::string const& path, Pistache::Http::ResponseWriter& response)
{
Pistache::Http::serveFile(response, path.get());
}
Also this will allow user to use exceptions to signal errors to REST API caller:
void MyHandlers::someEndpoint(Pistache::Http::ResponseWriter& response)
{
if (some_precondition_failed())
throw Pistache::Http::HttpError(500, "precondition has failed");
response.send(Pistache::Http::Code::Ok, "Success");
}