All samples scripts are now config based with a single bash entry point: bin/generate-samples.sh
.
File cleanup using the FILES
file will be done later.
Elm is currently skipped as it requires that we skip validation of the spec, so will need to be configured.
Running against the 179 configurations in bin/configs
I see the following stats:
[SUCCESS] Batch generation completed successfully.
./bin/generate-samples.sh 54.20s user 6.64s system 243% cpu 24.954 total
This should address conversation in #6333 (closed).
PR checklist
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project before. -
Run the shell script(s) under ./bin/
(or Windows batch scripts under.\bin\windows
) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the code or mustache templates for a language ({LANG}
) (e.g. php, ruby, python, etc). -
File the PR against the correct branch: master
,4.3.x
,5.0.x
. Default:master
. -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.