Skip to content
GitLab

[REQ][typescript-axios] useSingleRequestParameter should mark parameter optional if all properties are optional

Merged Administrator requested to merge github/fork/codeserk/feature/6440-typescript-axios-with-single-request-parameter-use-default-value into master

Created by: codeserk

This PR uses a default value to requestParameters (= {}) if all the parameters are optional.

fixes #6440 (closed)

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@benwiley4000 I think this is not exactly the solution you had in mind, but it should work alike: If all the parameters are optional, you can use it without parameters (myApiCall()). Using default parameter instead of making it optional makes it a bit less complex.

@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @nicokoenig @topce @akehir @petejohansonxo @amakhrov