[Java][RestTemplate] Fixed invalid URL-encoding of query parameters (!646) · Merge requests · OpenAPI Tools / openapi-generator

Merged Administrator requested to merge github/fork/rubms/Fix_#644 into master Jul 25, 2018

Created by: rubms

PR checklist

Read the contribution guidelines.
Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
Filed the PR against the correct branch: master, 3.2.x, 4.0.x. Default: master.
Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fix for https://github.com/OpenAPITools/openapi-generator/issues/644. Changed the way the URI is created from the given query parameters in ApiClient::invokeAPI in order to prevent a double escaping of % characters in the URL.

The #249 (closed) issue originally addresses the problem in the URL-encoding of query parameters in the Java RestTemplate client generation. A fix is attempted in #260, but without full success, in which this re-encoding of % characters is experienced.

https://github.com/OpenAPITools/openapi-generator/pull/260 PR cc: @jmini @wing328 @simingweng technical committee cc: @bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01)