Skip to content
GitLab

[all] Fix inconsistent parameter names when ensuring uniqueness.

Merged Administrator requested to merge github/fork/Jauler/fix_inconsistent_parameters into master

Created by: Jauler

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.2.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

If parameter renaming takes place while ensuring unique names in DefaultCodegen.java fromOperation method, parameter lists queryParams, pathParams, headerParams, cookieParams are not updated accordingly which causes wrong parameters to be selected when using {{#pathParams}}, {{#queryParams}} etc. in mustache templates.