Typescript-rxjs: print param name (!6368) · Merge requests · OpenAPI Tools / openapi-generator

Merged Administrator requested to merge github/fork/jvandort/tx_rxjs_print_param_name into master May 19, 2020

Created by: jvandort

This updates throwIfNullOrUndefined to take in & print the name of the parameter being checked. This PR in response to this comment here.

The signature of throwIfNulllOrUndefined was changed to make nickname non-optional, but based on apis.mustache the param will never be undefined. Granted, the change is breaking, but this is also merging into 5.0.x. I considered removing the other deprecated exports in runtime.mustache (since this is merging into 5.0.x), but I figured I would not in this PR and ask for opinions about that here.

PR checklist

Read the contribution guidelines.
If contributing template-only or documentation-only changes which will change sample output, build the project before.
Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)