Merged
requested to merge github/fork/Jauler/cpprestsdk_invalid_characters_in_identifiers into master
Created by: Jauler
PR checklist
-
Read the contribution guidelines. -
Ran the shell script under ./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
. -
Filed the PR against the correct branch: master
,3.1.x
,4.0.x
. Default:master
. -
Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
Description of the PR
Proposed fix for #621 (closed). Add cpp identifier sanitizing to AbstractCppCodegen.java and provide those functions for other cpp codegens if needed.
NOTE: After adding to AbstractCppCodegen.java it is possible to remove some overriden functions from other (than cpprestsdk) cpp generators, but I wanted to avoid that as I have no setup for testing those.
@ravinikam (2017/07) @stkrwork (2017/07) @fvarose (2017/11) @etherealjoy (2018/02) @MartinDelille (2018/03)