Closed
requested to merge github/fork/Chr1st0ph/fix/issue-6069-request-headers-are-sent-in-body into master
Created by: Chr1st0ph
This is a fix for https://github.com/OpenAPITools/openapi-generator/issues/6069
My first try to solve this issue (https://github.com/OpenAPITools/openapi-generator/issues/5249) failed pitiful because of different reasons. In order to verify the results of this change ( also for future changes ) I added a first test-case for Feign-client-code-generation.
This test-case is quite complex.
Possible alternatives ( imho ):
- Integration-test using a generated Feign-client instance for talking to a mock-server
- simple string-comparison of generated code
PR checklist
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project before. -
Run the shell script(s) under ./bin/
(or Windows batch scripts under.\bin\windows
) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the code or mustache templates for a language ({LANG}
) (e.g. php, ruby, python, etc). -
File the PR against the correct branch: master
,4.3.x
,5.0.x
. Default:master
. -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.