Created by: tomelfring
Fixes a part of #6225 (closed), where the default values aren't registered correctly due to a mismatch in comparing between name
and baseName
in the class CSharpClientCodegen.java
.
Chosen for comparing name
because that's the value used more in the same file.
Testcase is already in the samplefiles at:
samples/client/petstore/csharp/OpenAPIClient/src/Org.OpenAPITools/Model/Cat.cs
The default value of className
is now set to "Cat"
instead of default(string)
.
Additional testcase is provided in #6225 (closed).
To fix #6225 (closed)
PR checklist
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project before. -
Run the shell script(s) under ./bin/
(or Windows batch scripts under.\bin\windows
) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the code or mustache templates for a language ({LANG}
) (e.g. php, ruby, python, etc). -
File the PR against the correct branch: master
,4.3.x
,5.0.x
. Default:master
. -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@mandrean (2017/08), @jimschubert (2017/09)