Created by: sebastien-rosset
Currently when invoking the getattr, setattr, hasattr functions, the generated ApiKeyError exception is raised. This causes non-standard, non-compliant behavior.
This PR change the implementation (use AttributeError) to ensure compliance with the Python documentation:
- The builtin getattr function has the following contract: If the named attribute does not exist, default is returned if provided, otherwise AttributeError is raised.
- The builtin hasattr function returns True if the string is the name of one of the object’s attributes, False if not. (This is implemented by calling getattr(object, name) and seeing whether it raises an AttributeError or not.)
Similarly for the setattr function
PR checklist
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project before. -
Run the shell script(s) under ./bin/
(or Windows batch scripts under.\bin\windows
) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the code or mustache templates for a language ({LANG}
) (e.g. php, ruby, python, etc). -
File the PR against the correct branch: master
,4.3.x
,5.0.x
. Default:master
. -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.