Don't use visible = true in Java model classes (!613) · Merge requests · OpenAPI Tools / openapi-generator

Closed Administrator requested to merge github/fork/delenius/java-polymorphism into master Jul 21, 2018

Created by: delenius

This causes errors when deserializing polymorphic classes.

PR checklist

Read the contribution guidelines.
Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
Filed the PR against the correct branch: master, 3.1.x, 4.0.x. Default: master.
Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

When deserializing polymorphic classes using a discriminator property in the Java client, I get these errors from Jackson:

javax.ws.rs.ProcessingException: com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException: Unrecognized field <fieldname> not marked as ignorable

This is because we have @JsonTypeInfo(..., visible = true) in the model classes. This PR removed the visible = true part, which fixes the problem.

Tagging Java tech committee: @bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01)