Created by: sebastien-rosset
It looks like recently something changed because the JSON schema null
type is now causing problems. I'm not sure what specific commit caused this problem. The getTypeString
function in PythonClientExperimentalCodegen.java is incorrectly returning null
when the input Schema is the Null type.
For example, with the following schema, the generated python-experimental code has syntax errors.
Foo:
oneOf:
- type: 'null'
- '#/components/schemas/Bar'
Without this PR, the following import is incorrectly generated:
try:
from openapi_client.models import null
except ImportError:
null = sys.modules[
'openapi_client.models.null']
PR checklist
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project before. -
Run the shell script(s) under ./bin/
(or Windows batch scripts under.\bin\windows
) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the code or mustache templates for a language ({LANG}
) (e.g. php, ruby, python, etc). -
File the PR against the correct branch: master
,4.3.x
,5.0.x
. Default:master
. -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.