fixes #6072 (closed)
When using git worktree
, the .git directory is in a different location than configured in the git id plugin.
This PR relaxes the errors that may be exposed by the git id plugin and protects against NPE when it does not generate version information.
This will cause the long-form version information to display like:
openapi-generator-cli 4.3.1-SNAPSHOT
commit : unknown
built : -999999999-01-01T00:00:00+18:00
source : https://github.com/openapitools/openapi-generator
docs : https://openapi-generator.tech/
Which should be fine.
An alternative might be for users to pass -Dmaven.gitcommitid.skip=true
, but this would require documentation which users may not easily find. Opting for dropping the supplemental version information seems a better approach from the user perspective.
If contributors start using worktrees regularly, we'll look into another option.
PR checklist
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project before. -
Run the shell script(s) under ./bin/
(or Windows batch scripts under.\bin\windows
) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the code or mustache templates for a language ({LANG}
) (e.g. php, ruby, python, etc). -
File the PR against the correct branch: master
,4.3.x
,5.0.x
. Default:master
. -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.