Skip to content
GitLab

[Python-experimental] Use DER encoding for ECDSA signatures, add parameter to configure hash algorithm

Merged Administrator requested to merge github/fork/CiscoM31/python-ecdsa-signature-encoding into master

Created by: sebastien-rosset

ECDSA signatures can be encoded using raw binary or ASN.1 encoding. This PR uses the same ASN1 encoding as the go-experimental implementation.

Add hash algorithm parameter in the configuration.py for HTTP signatures.

The IETF is still actively working on the draft and I opened an issue with the IETF HTTP working group to clarify the encoding of ECDSA signatures.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.