Skip to content
GitLab

[codegen] Fix 'super.HashCode' for oneOf and allOf Implementations (retry)

Merged Administrator requested to merge github/fork/jburgess/superHashcode1 into master

Created by: jburgess

This fixes various client and server generators which use allOf and discriminator patterns as identified in #5587

This error occurs as the hasVars boolean is not set for models which contain extension patterns. This fix simply sets the boolean at the end of code generation bases on the existence of variables after post-processing these special object types.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @bkabrda