Skip to content
GitLab

[mysql] Add OAuth2 framework tables

Merged Administrator requested to merge github/fork/ybelenko/3550-mysql-oauth-schema into master

Created by: ybelenko

Database schema copied from oauth2-server-php-mysql repo.

I can't say that I'm fully satisfied with mentioned schema. My complaints are:

  • oauth_users.password column limited to 80 characters which can be not enough for future password encryption algorithms. In PHP docs password_hash recommended length is 255.
  • Schema doesn't set column collations. It's important for case-sensitive tokens(base64 e.g.). More info in submitted issue
  • It's not obvious that oauth_users.username is user_id mentioned in other tables. Maybe column comment can make it more clear.

Tables structure described in related issue.

Closes #3550 (closed)

@jimschubert is welcome to review or throw an opinion.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.