Skip to content
GitLab

[Dart] Remove content type from header when content type is not specified

Merged Administrator requested to merge github/fork/gasugesu/dart2/accept_empty_content_type into master

Created by: gasugesu

The current Dart Client does not require ContentType to specify Content-type: application/json, which is incorrect.
There are two reasons.

  1. Specifying Content-type: application/json in header without declaration can be confusing.
  2. There may be no RequestBody at all. In such case, I don't think Content-type: application/json is correct.

Therefore, if ContentType is not specified, header should not add Content-type: application/json

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@ircecho (2017/07) @swipesight (2018/09) @jaumard (2018/09) @nickmeinhold (2019/09) @athornz (2019/12) @amondnet (2019/12)