Skip to content
GitLab

Fix NPE in body parameter due to incorrect parameter/consume

Merged William Cheng requested to merge fix_npe_body into master

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.1.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

After #383, a NPE will occur if form parameter is defined and consumes is set to applicataion/json.

This PR will fix the problem.

Tested with the spec in https://github.com/OpenAPITools/openapi-generator/pull/383#issuecomment-399863725 as well.

Follow-up: add a test case to fake petstore to catch the issue moving forward.