Created by: richardwhiuk
Currently, rust-server
's use
(i.e. import) a number of structs in models.rs
. This can cause namespace clashes, e.g. if there is a model named Header
, it will collide with hyper's Header
, which we import at the top of the file. Instead, we should use hyper; and then refer to hyper::Header
.
This was contributed by @mirw and reviewed by myself on behalf of @Metaswitch.
(Similarly discussed with respect to Swing in https://openapi-generator.slack.com/archives/CLSB0U0R5/p1582712193020000 )
Rust Server Technical Committee
- @frol
- @farcaller
- @bjgill
PR checklist
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project before. -
Run the shell script(s) under ./bin/
(or Windows batch scripts under.\bin\windows
) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the code or mustache templates for a language ({LANG}
) (e.g. php, ruby, python, etc). -
File the PR against the correct branch: master
,4.3.x
,5.0.x
. Default:master
. -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.