Created by: bjgill
PR checklist
-
Read the contribution guidelines. -
Ran the shell script under ./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
. -
Filed the PR against the correct branch: master
,3.1.x
,4.0.x
. Default:master
. -
Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @farcaller @frol
Description of the PR
We were previously relying on some incorrect behaviour of the old swagger-codegen mustache engine. See https://github.com/OpenAPITools/openapi-generator/issues/307#issuecomment-404465569 for a description of the error.
This PR switches some (incorrect) usage of headers
over to use hasHeaders
instead.
I've not done any specific testing. However, given that the sample is unchanged (apart from the test that we can now re-enable), I'm happy that this is not going to regress anything.