Skip to content
GitLab

[C-libcurl] The name in API parameter should not be escaped

Merged Administrator requested to merge github/fork/ityuhui/yhworking into master

Created by: ityuhui

To fix the issue #5101

The name "x-api-token" in API spec includes the c keyword "-", and it is escaped:

if (x_api_token) {
    keyHeader_x_api_token = strdup("x_api_token");  <--should not be escaped here
    valueHeader_x_api_token = strdup((x_api_token));

Now the fix will not escape:

if (x_api_token) {
    keyHeader_x_api_token = strdup("x-api-token");  <--It is right now
    valueHeader_x_api_token = strdup((x_api_token));

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328 @zhemant