Created by: michelealbano
I worked on the C-libcurl client. It was crashing when working on models with additionalProperties (see issue #5395 (closed)). I found 2 problems:
- the generator was creating too many nodes one into the other
- when the additionalProperties were using native datatypes (booleans, etc), it was not allocating memory for them - but was trying to "free" them
I verified the json I produce now against json produced by the python client when I use integers as additionalProperties. They both produce this JSON now: { "orchestrationFlags": { "onlyPreferred": 0, "overrideStore": 1 } }
There is still a problem with booleans, but I will solve it later.
@zhemant @ityuhui
PR checklist
- [ X ] Read the contribution guidelines.
- [ X ] If contributing template-only or documentation-only changes which will change sample output, build the project before.
- [ X ] Run the shell script(s) under
./bin/
(or Windows batch scripts under.\bin\windows
) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the code or mustache templates for a language ({LANG}
) (e.g. php, ruby, python, etc). - [ X ] File the PR against the correct branch:
master
,4.3.x
,5.0.x
. Default:master
. - [ X ] Copy the technical committee to review the pull request if your PR is targeting a particular programming language.