Created by: richardwhiuk
For objects, which contain arrays of wrapped strings - e.g.
ObjectWithArrayOfObjects:
type: object
properties:
objectArray:
type: array
items:
$ref: '#/components/schemas/StringObject'
StringObject:
type: string
This currently produces:
struct ObjectWithArrayOfObjects {
objectArray: Option<Vec<String>>
}
struct StringObject(String);
whereas we should be doing:
struct ObjectWithArrayOfObjects {
objectArray: Option<Vec<StringObject>>
}
struct StringObject(String);
We actually get it right in one place (when converting header parameters), and wrong in the model definition, which breaks some APIs.
Commits are broken down into:
- Fixing the bug
- Adding a test case
- Updating the samples
Contribution by myself on behalf of @Metaswitch. Reviewed by @mirw
Rust Technical Committee
@frol @farcaller @bjgill
PR checklist
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project before. -
Run the shell script(s) under ./bin/
(or Windows batch scripts under.\bin\windows
) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the code or mustache templates for a language ({LANG}
) (e.g. php, ruby, python, etc). -
File the PR against the correct branch: master
,4.3.x
,5.0.x
. Default:master
. -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.