Created by: spacether
Our Bitrise Swift4 tests keep failing It appears that the last time that the test worked was 6 days ago in this PR: https://github.com/OpenAPITools/openapi-generator/pull/4940 Since then 19 PRs have been submitted, all of which are failing Swift4 tests in Bitrise This PR comments out the Swift4 testing so we can:
- fix Swift4 later
- get back to having all of our CI tests pass for any open or updated PRs
This PR fixes this issue: https://github.com/OpenAPITools/openapi-generator/issues/4990
PR checklist
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project before. -
Run the shell script(s) under ./bin/
(or Windows batch scripts under.\bin\windows
) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the code or mustache templates for a language ({LANG}
) (e.g. php, ruby, python, etc). -
File the PR against the correct branch: master
,4.3.x
,5.0.x
. Default:master
. -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
Core Team: @wing328 (2015/07) @jimschubert (2016/05) @cbornet (2016/05) @ackintosh (2018/02) @jmini (2018/04) @etherealjoy (2019/06)
Swift Team: @jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11)