Closed
requested to merge github/fork/shybovycha/enhancement-4.3.x/add-builders-to-models into master
Created by: shybovycha
As per #2415, adding builders generation for models.
The reasons for this change are:
- currently the setters do not have the
set
prefix, which makes models not comply with java beans requirements - constructing models becomes painful, specifically when they have numerous fields
Compare the current way to construct a model to the proposed one:
now:
new Model().property1(value1).property2(value2)
// getters/setters
myModel.getProperty1();
myModel.property1(value1);
proposed:
Model.builder().property1(value1).property2(value2).build()
// getters/setters
myModel.getProperty1();
myModel.setProperty1(value1);
PR checklist
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project before. -
Run the shell script(s) under ./bin/
(or Windows batch scripts under.\bin\windows
) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the code or mustache templates for a language ({LANG}
) (e.g. php, ruby, python, etc). -
File the PR against the correct branch: master
,4.3.x
,5.0.x
. Default:master
. -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.