Created by: spacether
python-flask-python2 tests were previously failing and were disabled in https://github.com/OpenAPITools/openapi-generator/commit/62e5d1f43bfdf0c9298841b596e002cd9feab570 They were failing because the latest python connexion library was being installed, which was not python 2.7 compatible This was fixed in https://github.com/OpenAPITools/openapi-generator/pull/4765 The only remaining step is to turn the CI tests back on and they should pass That's what we're doing here
Issues Impacted
If merged, this PR will close https://github.com/OpenAPITools/openapi-generator/issues/4823
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project before. -
Run the shell script(s) under ./bin/
(or Windows batch scripts under.\bin\windows
) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the code or mustache templates for a language ({LANG}
) (e.g. php, ruby, python, etc). -
File the PR against the correct branch: master
,4.3.x
,5.0.x
. Default:master
. -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
Python Technical Committee: @taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10) @Jyhess (2019/01) @slash-arun (2019/11) @spacether (2019/11)