Created by: 4brunu
This PR allows the Swift4 generator to parse dates with the format ISO8601 with and without milliseconds.
It introduced a breaking change, by deprecating Configuration.dateFormat which is replaced by CodableHelper.dateFormatter, which means that now when someone want's a custom date formatter, instead of providing a string, they will have to provide a DateFormatter which gives more flexibility. If someone is changing Configuration.dateFormat they will receive a compilation error that informs that they should now use CodableHelper.dateFormatter instead. If someone is using the default Configuration.dateFormat value, this will be transparent.
This PR fixes https://github.com/OpenAPITools/openapi-generator/issues/699 and it's a continuation of https://github.com/OpenAPITools/openapi-generator/pull/1454.
PR checklist
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project before. -
Run the shell script(s) under ./bin/
(or Windows batch scripts under.\bin\windows
) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the code or mustache templates for a language ({LANG}
) (e.g. php, ruby, python, etc). -
File the PR against the correct branch: master
,4.3.x
,5.0.x
. Default:master
. -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11)