Skip to content
GitLab

[Slim4] Add array support to Data Mocker

Merged Administrator requested to merge github/fork/ybelenko/slim_data_mocker_array into master

Created by: ybelenko

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

mockArray method added to interface and implemented class. Mocker creates smallest arrays(single item when possible) to avoid huge JSON responses.

Related to #3545 (closed)

How to test

  1. Checkout into feature branch
$ git checkout -b ybelenko-slim_data_mocker_array master
$ git pull https://github.com/ybelenko/openapi-generator.git slim_data_mocker_array
  1. Generate new Slim4 samples and go to just created build
$ mvn clean package
$ bin/php-slim4-server-petstore.sh
$ cd samples/server/petstore/php-slim4
  1. Start Composer installation and run unit tests
$ composer install
$ composer test
$ composer phpcs

cc @jebentier, @dkarlovi, @mandrean, @jfastnacht, @ackintosh, @renepardon