Created by: zbarbuto
Relates to https://github.com/OpenAPITools/openapi-generator/pull/120
This PR removes services from the providers
array in @NgModule
s when providedInRoot
mode is on.
Listing the providers in the providers
array is not required if using providedIn: 'root'
syntax. By excluding the providers from this array, the ones that are not used can be tree shaken out and excluded from the final build.
More info here:
https://angular.io/guide/providers#providedin-and-ngmodules
Without this change, all services are bundled in a final production bundle, regardless of if they are injected or not.
PR checklist
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project before. -
Run the shell script(s) under ./bin/
(or Windows batch scripts under.\bin\windows
) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the code or mustache templates for a language ({LANG}
) (e.g. php, ruby, python, etc). -
File the PR against the correct branch: master
,4.3.x
,5.0.x
. Default:master
. -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
cc @topce @akehir