Skip to content
GitLab

[BUG][PHP] Parameter property style not fully implemented

Merged Administrator requested to merge github/fork/spysystem/th_bug_fix_php_parameter_property_style_not_fully_implemented into master

Created by: thomasphansen

(related to #4042)

(Fixes issue #4641 (closed))

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@jebentier @dkarlovi @mandrean @jfastnacht @ackintosh @ybelenko @renepardon

PR #4042 aims to expose style and explode parameter properties to mustache templates. However, this only fully works inside allParams loops - queryParams only receive the explode property, while style remains empty.

The reason for this is because CodegenParameter.java has not fully implemented the style property: it contains only its declaration as a property, but it doesn't deal with it inside its methods - explode, however, is fully implemented there.

I got into this because I'm dealing with PR #3984, which I need to generate a library. Unfortunately, that code is broken due to always getting an empty style, since it loops queryParams. This last one receives copies of allParams parameters, and since the style property is not being copied, it remains empty.