Created by: tobymurray
Resolves #4535 (closed)
Updated the Gradle version used in the generated Java client projects, as well as the samples. For my own use case (using OkHttp), the generated Java jar works without any changes, but I have no customizations in my build.gradle
that may cause issues.
So far as I can tell, Gradle is backwards compatible in the capacity it's used within these Java projects. With that said, this does not update the Gradle build script files to what would be more idiomatic of current Gradle, as I'm hoping the smaller the change the less contentious it is. A logical follow up of this would be to update e.g. build.gradle.mustache
to reflect some of changes Gradle has made in the last few years.
@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608
PR checklist
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project before. -
Run the shell script(s) under ./bin/
(or Windows batch scripts under.\bin\windows
) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the code or mustache templates for a language ({LANG}
) (e.g. php, ruby, python, etc). -
File the PR against the correct branch: master
,4.3.x
,5.0.x
. Default:master
. -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.