Issue was found during community contribution work in #4454 for an unrelated feature.
The logic to apply a default artifactVersion was faulty, resulting in generation without an explicit version specified either on the OpenAPI Document or at the CLI/plugin level would result in poms generated with
<version></version>As an example, in any commit made up to 5 weeks before this commit, run:
./bin/java-pkmst-petstore-server.shThe solution is to ensure that artifactVersion isn't overwritten by an "in-process" additonalProperties map, and also to ensure that additionalProperties is synced with the artifactVersion property once it has been modified.
As a future task, we'll want to move any modification of additionalProperties outside of preprocessOpenAPI (to processOpts). We're hiding manipulation of the "Opts" at a point where we should really only be applying logic on top of the OpenAPI doc.
cc java technical committee: @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)
PR checklist
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project before. -
Run the shell script(s) under ./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc). -
File the PR against the correct branch: master,4.3.x,5.0.x. Default:master. -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.