Merged
requested to merge github/fork/roxspring/feature/gh-4449-dart-keywords-as-resource into master
Created by: roxspring
#4449 introduced a dependency on to a relative file location and means that ./bin/run-all-petstore
produces error messages when used. I've switched this to load as a resource from the classpath instead.
@nickmeinhold, @wing328 were involved in the original MR and are probably best to review.
PR checklist
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project before. -
Run the shell script(s) under ./bin/
(or Windows batch scripts under.\bin\windows
) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the code or mustache templates for a language ({LANG}
) (e.g. php, ruby, python, etc). -
File the PR against the correct branch: master
,4.3.x
,5.0.x
. Default:master
. -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.