Created by: ybelenko
PR checklist
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project before. -
Run the shell script(s) under ./bin/
(or Windows batch scripts under.\bin\windows
) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the code or mustache templates for a language ({LANG}
) (e.g. php, ruby, python, etc). -
File the PR against the correct branch: master
,4.3.x
,5.0.x
. Default:master
. -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
Closes #4217 (closed)
I didn't add any tests, because underscore search is pretty basic in current PR. I can add tests if necessary.
Examples of new warnings:
[main] WARN o.o.codegen.DefaultCodegen - Security schema 'api_key' mapped to
underscored header 'api_key' which is forbidden in Apache and Nginx webservers
by default.
https://stackoverflow.com/questions/22856136/why-http-servers-forbid-underscores-in-http-header-names/22856867#22856867
[main] WARN o.o.codegen.DefaultCodegen - Request header parameter name
'enum_header_string_array' contains underscore which is forbidden in Apache
and Nginx webservers by default.
https://stackoverflow.com/questions/22856136/why-http-servers-forbid-underscores-in-http-header-names/22856867#22856867
[main] WARN o.o.codegen.DefaultCodegen - Response header name 'X_Rate_Limit'
contains underscore which is forbidden in Apache and Nginx webservers by
default.
https://stackoverflow.com/questions/22856136/why-http-servers-forbid-underscores-in-http-header-names/22856867#22856867
cc @OpenAPITools/generator-core-team