Skip to content
GitLab

[Slim] Refactoring

Merged Administrator requested to merge github/fork/ybelenko/slim_refactoring into master

Created by: ybelenko

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.1.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

I found beautiful AbstractPhpCodegen class. In this pull request PhpSlimServerCodegen gets new config options and extends AbstractPhpCodegen. Now Slim codegen much smaller and cleanier. Also I noticed old LICENSE file in Slim samples. Current codegen doesn't create LICENSE file for Slim, so I've deleted it.

cc @jebentier @dkarlovi @mandrean @jfastnacht @ackintosh