Skip to content
GitLab

[go-experimental] export required fields without pointer

Merged Administrator requested to merge github/fork/shaxbee/go-exp-required-fields-nullable into master

Created by: shaxbee

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

@bkabrda

Required fields are exposed without pointer, as they cannot be set to nil. This reduces boilerplate and GC pressure. Omitempty tag is only used for fields that are neither required or nullable. This removes need for private member that breaks struct conversions. This also removes need for custom MarshalJSON that creates intermediary map increasing GC pressure.