Created by: JFCote
PR checklist
-
Read the contribution guidelines. -
Ran the shell script under ./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
. -
Filed the PR against the correct branch: master
,3.1.x
,4.0.x
. Default:master
. -
Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
Description of the PR
This is to fix problem identified here: https://github.com/OpenAPITools/openapi-generator/issues/185
I didn't run the shell scripts since it touch DefaultCodegen.java
and I want the advice of the core team before I generate everything. The other reason is that I'm not sure how to re-generate ALL the samples. Will need your help with that :)
Feedback is welcome!
@wing328 (2015/07) @jimschubert (2016/05) @cbornet (2016/05) @jaz-ah (2016/05) @ackintosh (2018/02) @JFCote (2018/03) @jmini (2018/04)