Created by: JFCote
PR checklist
-
Read the contribution guidelines. -
Ran the shell script under ./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first. -
Filed the PR against the correct branch: master
,4.1.x
,5.0.x
. Default:master
. -
Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10) @akehir (2019/07)
Description of the PR
I've change my mind on how to fix that "bug".
In the bug itself, I was suggesting to do like in version 3.X.X and have an "option" parameter in each call but I realized that was no a very good design.
Once I understood how the code was refactored in 4.X.X, the only thing missing was to be able to provide additional headers
with each Fetch query in the Configuration
object. Also, the credentials
option was missing, so I added it. Very simple PR with no breaking change and no risk :)
fixes #3402 (closed)