Created by: dkliban
PR checklist
-
Read the contribution guidelines. -
Ran the shell script under ./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first. -
Filed the PR against the correct branch: master
,4.1.x
,5.0.x
. Default:master
. -
Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
Description of the PR
Solution: move leading _ to the end of the name
Double leading underscores in Python attribute names cause them to have their names mangled as described in PEP 8[0]. That's why they were being removed completely before this patch.
Due to the implementation details of the python models that are generated, leaving a single leading underscore causes a conflict between setters of variables name that differ only by a leading underscore. e.g.: 'name' and '_name'.
This patch changes how leading underscores in variables and parameters are handled. All leading underscores are moved to the end of the name.