Skip to content
GitLab

[C++][Pistache] Do not use JSON for primitive types in request body

Merged Administrator requested to merge github/fork/muttleyxd/pistache-body-not-always-json into master

Created by: muttleyxd

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @ravinikam @stkrwork @etherealjoy @MartinDelille

Description of the PR

Request body can contain any input, simple strings, CSV text or something else.

I have specified my request body like this:

    requestBody:
      content:
        text/csv:
          schema:
            type: string

Is it possible to check for content type of request body in Mustache template?

Current behavior is to parse request's body as if it's json. This causes any request to fall into 400 bad request exception branch, which means user provided handlers aren't executed at all.