Merged
requested to merge github/fork/grokify/go/client/fix/parameter-collectionformat-multi into master
Created by: grokify
PR checklist
-
Read the contribution guidelines. -
Ran the shell script under ./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first. -
Filed the PR against the correct branch: master
,4.1.x
,5.0.x
. Default:master
. -
Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
@antihax @bvwells @kemokemo
Description of the PR
This PR fixes parameters which use collectionFormat=multi
so that duplicate keys (but different values) are sent in the query string instead of a single key with a single CSV concatenated value.
See description of bug here:
https://github.com/OpenAPITools/openapi-generator/issues/3386
Notes
This PR doesn't introduce any breaking changes and is built on the existing antihax/optional.Interface
type for an optional []string
.
For a breaking change, it would be nice to implement an []string
in the optional structs and only use if the array has one or more elements.
For example, the following is currently generated:
type APIOpts struct {
Name optional.String
UserIds optional.Interface
}
It may be better to generate:
type APIOpts struct {
Name optional.String
UserIds []string
}