Skip to content
GitLab

[fix] Assign template directory to additional properties

Merged Jim Schubert requested to merge github/fork/jimschubert/fix-3364 into master

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

As part of settings refactor, I had missed assigning the value of templateDir to additional properties. This result in 4.1.0-SNAPSHOT branch with borked custom template support.

This PR makes that asignment, and fixes some other potential issues with internal state in CodegenConfigurator (set* methods).

Added a unit test which evaluates additional properties exist on a CodegenConfig instance after calling processOpts(). The test is limited to those properties known to be processed by DefaultCodegen.

cc @OpenAPITools/generator-core-team fixes #3364 (closed)