Skip to content
GitLab

Use io.swagger.util.Yaml instead of io.swagger.v3.core.util.Yaml to add quotes around string value and fix compatibility with parser using yaml 1.1.

Closed Administrator requested to merge github/fork/GuillaumeSmaha/revert_minimize_quotes_for_compatibility into master

Created by: GuillaumeSmaha

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fix #3196

In spec 1.1, some words without quotes can be implicitly converted to a boolean like "yes" or "on" (See https://yaml.org/type/bool.html) In v3.core.util.Yaml with MINIMIZE_QUOTES enabled, the formatter created a YAML but forget to protect some words.

PRs are created to fix this in the formatter:

Until the PRs will be merged and released, this patch fix it by re-adding quotes.