PR checklist
-
Read the contribution guidelines. -
Ran the shell script under ./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first. -
Filed the PR against the correct branch: master
,. Default:3.4.x
,4.0.x
master
. -
Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
Description of the PR
Limited reviewer request since this is a fairly simple change. #2388 introduced a somewhat cyclical dependency (openapi-generator-cli
-> openapi-generator
-> openapi-generator-cli
). @jmini is working on an alternative method to enable better debugging during new generator development. As discussed in chat, we'd want this to fail in CI and the fix would be to avoid caching openapitools artifacts across builds.
This will likely fail until Jérémie's work is available and merged.